On 30/06/2021 09:31, Chen-Yu Tsai wrote: > On Thu, Jun 17, 2021 at 7:01 AM Chun-Jie Chen > <chun-jie.chen@xxxxxxxxxxxx> wrote: >> >> On MT8195, tuner_en_reg is moved to register offest 0x0. >> If we only judge by tuner_en_reg, it may lead to wrong address. >> Add tuner_en_bit to the check condition. And it has been confirmed, >> on all the MediaTek SoCs, bit0 of offset 0x0 is always occupied by >> clock square control. >> >> Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> > > Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > Though you might want to consider converting these types of checks into feature > flags. > Yes I think adding a feature flag is the way to go. Luckily there are only a few SoCs that will need updates at the same time. Regards, Matthias
