On 28/06/2021 15:15, Chun-Jie Chen wrote: > On Fri, 2021-06-25 at 11:07 +0200, Enric Balletbo i Serra wrote: >> Hi Chun-Jie Chen, >> >> Thank you for your patch. >> >> On 16/6/21 2:06, Chun-Jie Chen wrote: >>> Add domain control data including bus protection data size >>> change due to more protection steps in mt8195 and wakeup flag >>> in power domain for wakeup control in suspend. >>> >> >> The wakeup flag is used for different SoCs apart from mt8195, isn't >> it? I'd add >> this on a separate patch so it is not dependent on the mt8195 >> changes. This will >> also make more clear that is not really a mt8195 thing and can help >> in case at >> some point we need to run a bisection because something is broken on >> another SoC. >> >> Thanks, >> Enric >> >> > > Yes, this wakeup flag also is used by other SoC like MT8173, but > missing this flag in new power domain driver(mtk-pm-domain.c). > I will separate this modification of wakeup flag from this patch but > put it in same series. > Sounds perfect. Regards, Matthias