On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: > > mt8183 i2c pins don't support PUPD register, so change to use generic > pin configs instead of let it fail and fallback. > > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> On a side note, the `mediatek,pull-up-adv` property probably should be merged into `bias-pull-up` with an argument.