Hi Jonathan, I love your patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on robh/for-next v5.13-rc7 next-20210625] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jonathan-Cameron/dt-bindings-iio-dac-Add-most-missing-binding-documents/20210628-003216 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: powerpc-allmodconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4f70da9b9819945461961ccdfbd87438ac8a9f89 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jonathan-Cameron/dt-bindings-iio-dac-Add-most-missing-binding-documents/20210628-003216 git checkout 4f70da9b9819945461961ccdfbd87438ac8a9f89 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/iio/dac/ad5624r_spi.c: In function 'ad5624r_probe': drivers/iio/dac/ad5624r_spi.c:296:12: error: invalid storage class for function 'ad5624r_remove' 296 | static int ad5624r_remove(struct spi_device *spi) | ^~~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:296:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 296 | static int ad5624r_remove(struct spi_device *spi) | ^~~~~~ >> drivers/iio/dac/ad5624r_spi.c:317:1: warning: 'alias' attribute ignored [-Wattributes] 317 | MODULE_DEVICE_TABLE(spi, ad5624r_id); | ^~~~~~~~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:324:12: error: initializer element is not constant 324 | .remove = ad5624r_remove, | ^~~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:324:12: note: (near initialization for 'ad5624r_driver.remove') In file included from include/linux/device.h:32, from arch/powerpc/include/asm/io.h:27, from include/linux/io.h:13, from include/linux/irq.h:20, from arch/powerpc/include/asm/hardirq.h:6, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from drivers/iio/dac/ad5624r_spi.c:8: drivers/iio/dac/ad5624r_spi.c:327:19: error: invalid storage class for function 'ad5624r_driver_init' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~ include/linux/device/driver.h:259:19: note: in definition of macro 'module_driver' 259 | static int __init __driver##_init(void) \ | ^~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/bpf.h:19, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from include/linux/regulator/consumer.h:35, from drivers/iio/dac/ad5624r_spi.c:15: include/linux/module.h:130:42: error: invalid storage class for function '__inittest' 130 | static inline initcall_t __maybe_unused __inittest(void) \ | ^~~~~~~~~~ include/linux/device/driver.h:263:1: note: in expansion of macro 'module_init' 263 | module_init(__driver##_init); \ | ^~~~~~~~~~~ include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver' 315 | module_driver(__spi_driver, spi_register_driver, \ | ^~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: warning: 'alias' attribute ignored [-Wattributes] In file included from include/linux/device.h:32, from arch/powerpc/include/asm/io.h:27, from include/linux/io.h:13, from include/linux/irq.h:20, from arch/powerpc/include/asm/hardirq.h:6, from include/linux/hardirq.h:11, from include/linux/interrupt.h:11, from drivers/iio/dac/ad5624r_spi.c:8: drivers/iio/dac/ad5624r_spi.c:327:19: error: invalid storage class for function 'ad5624r_driver_exit' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~ include/linux/device/driver.h:264:20: note: in definition of macro 'module_driver' 264 | static void __exit __driver##_exit(void) \ | ^~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~~~~ include/linux/device/driver.h:264:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 264 | static void __exit __driver##_exit(void) \ | ^~~~~~ include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver' 315 | module_driver(__spi_driver, spi_register_driver, \ | ^~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/bpf.h:19, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from include/linux/regulator/consumer.h:35, from drivers/iio/dac/ad5624r_spi.c:15: include/linux/module.h:138:42: error: invalid storage class for function '__exittest' 138 | static inline exitcall_t __maybe_unused __exittest(void) \ | ^~~~~~~~~~ include/linux/device/driver.h:268:1: note: in expansion of macro 'module_exit' 268 | module_exit(__driver##_exit); | ^~~~~~~~~~~ include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver' 315 | module_driver(__spi_driver, spi_register_driver, \ | ^~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver' 327 | module_spi_driver(ad5624r_driver); | ^~~~~~~~~~~~~~~~~ drivers/iio/dac/ad5624r_spi.c:327:1: warning: 'alias' attribute ignored [-Wattributes] In file included from include/linux/module.h:21, from include/linux/bpf.h:19, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, vim +/alias +317 drivers/iio/dac/ad5624r_spi.c 6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 307 ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 308 static const struct spi_device_id ad5624r_id[] = { 14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 309 {"ad5624r3", ID_AD5624R3}, 14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 310 {"ad5644r3", ID_AD5644R3}, 14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 311 {"ad5664r3", ID_AD5664R3}, 14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 312 {"ad5624r5", ID_AD5624R5}, 14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 313 {"ad5644r5", ID_AD5644R5}, 14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 314 {"ad5664r5", ID_AD5664R5}, ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 315 {} ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 316 }; 55e4390cb04e8b drivers/staging/iio/dac/ad5624r_spi.c Lars-Peter Clausen 2011-11-16 @317 MODULE_DEVICE_TABLE(spi, ad5624r_id); ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 318 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
