On Thu, Jun 24, 2021 at 03:20:18PM -0600, Rob Herring wrote: > On Wed, Jun 16, 2021 at 01:27:00PM -0700, Drew Fustini wrote: > > Add DT binding documentation for the StarFive JH7100 Soc [1] and the > > BeagleV Starlight JH7100 board [2]. > > > > [1] https://github.com/starfive-tech/beaglev_doc > > [2] https://github.com/beagleboard/beaglev-starlight > > > > Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx> > > --- > > Note: my patch to add 'starfive' to vendor-prefixes.yaml was applied by > > Rob back on June 2: > > https://lore.kernel.org/linux-devicetree/20210602163200.GA3513985@xxxxxxxxxxxxxxxxxx/ > > > > I ran dt_binding_check and dtbs_check: > > > > $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dt_binding_check \ > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml > > CHKDT Documentation/devicetree/bindings/processed-schema-examples.json > > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json > > DTC Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml > > CHECK Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml > > > > $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check \ > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > DTC arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml > > CHECK arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml > > > > The files jh7100.dtsi and jh7100-beaglev-starlight.dts are in the > > process of being cleaned up for submission. The current downstream is: > > https://github.com/starfive-tech/linux/tree/beaglev/arch/riscv/boot/dts/starfive > > > > .../devicetree/bindings/riscv/starfive.yaml | 30 +++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/riscv/starfive.yaml > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > new file mode 100644 > > index 000000000000..4deae9f5c60d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > @@ -0,0 +1,30 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/riscv/starfive.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: StarFive SoC-based boards > > + > > +maintainers: > > + - Michael Zhu <michael.zhu@xxxxxxxxxxxxxxxx> > > + - Drew Fustini <drew@xxxxxxxxxxxxxxx> > > + > > +description: > > + SiFive SoC-based boards > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - items: > > + - const: beagle,beaglev-starlight-jh7100 > > + - const: starfive,jh7100 > > + > > + - items: > > + - const: starfive,jh7100 > > This alone shouldn't be valid. Thank you for pointing this out. I have removed that const item and the dtbs_check still completes ok. I will send a v2. Drew
