On Tue, Jun 15, 2021 at 08:33:56PM +1000, Alistair Francis wrote: > Initial support for the Silergy SY7636A Power Management chip > and regulator. > > Signed-off-by: Alistair Francis <alistair@xxxxxxxxxxxxx> > --- > .../bindings/mfd/silergy,sy7636a.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > new file mode 100644 > index 000000000000..9e50f57d5e8d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/silergy,sy7636a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: silergy sy7636a PMIC > + > +maintainers: > + - Alistair Francis <alistair@xxxxxxxxxxxxx> > + > +properties: > + compatible: > + const: silergy,sy7636a > + > + reg: > + maxItems: 1 > + > + '#thermal-sensor-cells': > + const: 0 > + > + epd-pwr-good-gpios: > + description: > + Specifying the power good GPIOs. As defined in bindings/gpio.txt. Drop the 2nd sentence. > + maxItems: 1 > + > + regulators: > + type: object > + > + properties: > + compatible: > + const: silergy,sy7636a-regulator > + > + "vcom": Don't need quotes. > + type: object > + $ref: /schemas/regulator/regulator.yaml# > + > + regulator-name: > + const: "vcom" Don't need quotes. Doesn't this belong in the 'vcom' node? You need another 'properties' and this under it. > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - '#thermal-sensor-cells' > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@62 { > + compatible = "silergy,sy7636a"; > + reg = <0x62>; > + status = "okay"; Don't show status in examples. > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_epdpmic>; > + #thermal-sensor-cells = <0>; > + > + regulators { > + compatible = "silergy,sy7636a-regulator"; > + reg_epdpmic: vcom { > + regulator-name = "vcom"; > + regulator-boot-on; > + }; > + }; > + }; > + }; > +... > -- > 2.31.1 > >
