Hi Paul,
于 Wed, 23 Jun 2021 19:34:15 +0100
Paul Cercueil <paul@xxxxxxxxxxxxxxx> 写道:
> Hi Zhou,
>
> Le mar., juin 22 2021 at 23:55:37 +0800, 周琰杰 (Zhou Yanjie)
> <zhouyanjie@xxxxxxxxxxxxxx> a écrit :
> > Add MAC syscon nodes for X1000 SoC and X1830 SoC from Ingenic.
> >
> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > Acked-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> > ---
> >
> > Notes:
> > v1->v2:
> > No change.
> >
> > arch/mips/boot/dts/ingenic/x1000.dtsi | 7 +++++++
> > arch/mips/boot/dts/ingenic/x1830.dtsi | 7 +++++++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi
> > b/arch/mips/boot/dts/ingenic/x1000.dtsi
> > index aac9ded..dec7909 100644
> > --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> > +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> > @@ -80,6 +80,11 @@
> >
> > status = "disabled";
> > };
> > +
> > + mac_phy_ctrl: mac-phy-ctrl@e8 {
> > + compatible = "syscon";
> > + reg = <0xe8 0x4>;
> > + };
>
> I acked this patch already, but you do need to update the CGU binding
> documentation as well.
Sure, I will send v3.
>
> -Paul
>
> > };
> >
> > ost: timer@12000000 {
> > @@ -347,6 +352,8 @@
> > clocks = <&cgu X1000_CLK_MAC>;
> > clock-names = "stmmaceth";
> >
> > + mode-reg = <&mac_phy_ctrl>;
> > +
> > status = "disabled";
> >
> > mdio: mdio {
> > diff --git a/arch/mips/boot/dts/ingenic/x1830.dtsi
> > b/arch/mips/boot/dts/ingenic/x1830.dtsi
> > index 59ca3a8..215257f 100644
> > --- a/arch/mips/boot/dts/ingenic/x1830.dtsi
> > +++ b/arch/mips/boot/dts/ingenic/x1830.dtsi
> > @@ -73,6 +73,11 @@
> >
> > status = "disabled";
> > };
> > +
> > + mac_phy_ctrl: mac-phy-ctrl@e8 {
> > + compatible = "syscon";
> > + reg = <0xe8 0x4>;
> > + };
> > };
> >
> > ost: timer@12000000 {
> > @@ -336,6 +341,8 @@
> > clocks = <&cgu X1830_CLK_MAC>;
> > clock-names = "stmmaceth";
> >
> > + mode-reg = <&mac_phy_ctrl>;
> > +
> > status = "disabled";
> >
> > mdio: mdio {
> > --
> > 2.7.4
> >
>
