On Thu, Jul 17, 2014 at 5:25 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote: > From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx> > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx> (...) > +static int qpnp_pinctrl_remove(struct platform_device *pdev) > +{ > + struct qpnp_pinctrl *qctrl = platform_get_drvdata(pdev); > + > + pinctrl_unregister(qctrl->ctrl); > + > + return gpiochip_remove(&qctrl->chip); We're removing the return value from gpiochip_remove() and I have dropped the __must_check attribute today, so just remove it unconditionally and return 0; Sorry for short and lame comment on a large patch I should look closer at, but atleast it's something. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html