Hi Paul,
于 Tue, 22 Jun 2021 15:05:25 +0100
Paul Cercueil <paul@xxxxxxxxxxxxxx> 写道:
> Hi Zhou,
>
> Le mar., juin 22 2021 at 21:51:19 +0800, 周琰杰
> <zhouyanjie@xxxxxxxxxxxxxx> a écrit :
> > Hi Paul,
> >
> > 于 Tue, 22 Jun 2021 13:46:57 +0100
> > Paul Cercueil <paul@xxxxxxxxxxxxxx> 写道:
> >
> >> Hi Zhou,
> >>
> >> Le mar., juin 22 2021 at 15:37:24 +0800, 周琰杰 (Zhou Yanjie)
> >> <zhouyanjie@xxxxxxxxxxxxxx> a écrit :
> >> > Change the "lcd-24bit" in the pinctrl groups to "lcd-8bit",
> >> > "lcd-16bit", "lcd-18bit", "lcd-24bit", since the pinctrl
> >> > driver has done the necessary splitting of the lcd group,
> >> > and it is convenient to further streamline the lcd-24bit
> >> > group in the subsequent pinctrl driver.
> >> >
> >> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> >> > ---
> >> > arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts
> >> > b/arch/mips/boot/dts/ingenic/gcw0.dts
> >> > index f4c04f2..dec3ba6f 100644
> >> > --- a/arch/mips/boot/dts/ingenic/gcw0.dts
> >> > +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
> >> > @@ -393,7 +393,7 @@
> >> > &pinctrl {
> >> > pins_lcd: lcd {
> >> > function = "lcd";
> >> > - groups = "lcd-24bit";
> >> > + groups = "lcd-8bit", "lcd-16bit", "lcd-18bit",
> >> > "lcd-24bit";
> >>
> >> No, I'm pretty sure this won't work, since "lcd-24bit" contains
> >> pins that are also contained by the other groups.
> >>
> >
> > Sure, it seems that we should modify the pinctrl first, then modify
> > the
> > dts, and then put them in the same series, so as to ensure that
> > they do
> > not cause damage.
>
> No, the "lcd-24bit" group is ABI now. We can't change it...
>
Sure.
Thanks and best regards!
> -Paul
>
> >
> > Thanks and best regards!
> >
> >> -Paul
> >>
> >> > };
> >> >
> >> > pins_uart2: uart2 {
> >> > --
> >> > 2.7.4
> >> >
> >>
> >
>
