On Mon, Jun 21, 2021 at 1:33 AM Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > > On Sun, Jun 20, 2021 at 11:27:49PM -0500, Jassi Brar wrote: > > On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > > > > > > On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote: > > > > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big > > > > cores) and CCI (Cache Coherent Interconnect). Although only APCS of > > > > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock > > > > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk' > > > > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO > > > > rather than PLATFORM_DEVID_NONE for platform_device_register_data() > > > > call. Otherwise, the second A53PLL clock registration will fail due > > > > to duplicate device name. > > > > > > > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' > > > > ... > > > > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk > > > > > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > > > > > Hi Jassi, > > > > > > Any comment on this patch? > > > > > 1) I was not on the CC list, so I don't have this patch in my mbox. > > That's strange. The patch series was sent with your address > <jassisinghbrar@xxxxxxxxx> on "To:" field. And that can be seen on > patch archive [1]. > Sorry, yes you are right. But I still can't find it in my inbox (and neither in spam).... perhaps I nuked it by mistake. anyways... > > 2) Shouldn't this patch be broken into a fix and an enablement patch? > > MSM8939 is the only platform that I know has multiple clusters and uses > APCS driver. So the change becomes a fix only when MSM8939 is enabled. > But if you prefer to separate the change, I will do so. > Yes, please. thanks.
