On Mon, Jun 21, 2021 at 5:03 PM <kewei.xu@xxxxxxxxxxxx> wrote: > @@ -1293,8 +1355,8 @@ static int mtk_i2c_parse_dt(struct device_node *np, struct mtk_i2c *i2c) > i2c->have_pmic = of_property_read_bool(np, "mediatek,have-pmic"); > i2c->use_push_pull = > of_property_read_bool(np, "mediatek,use-push-pull"); > - > - i2c_parse_fw_timings(i2c->dev, &i2c->timing_info, true); Looks like the patch removes the line accidentally.