Hi, On Mon, Jun 21, 2021 at 09:54:31AM +0100, Sudeep Holla wrote: > On Sun, Jun 20, 2021 at 11:09:21PM -0500, Jassi Brar wrote: > > On Mon, May 10, 2021 at 7:22 PM Peter Hilber > > <peter.hilber@xxxxxxxxxxxxxxx> wrote: > > > > ..... > > > > > --- a/drivers/mailbox/Kconfig > > > +++ b/drivers/mailbox/Kconfig > > > @@ -1,6 +1,7 @@ > > > # SPDX-License-Identifier: GPL-2.0-only > > > menuconfig MAILBOX > > > bool "Mailbox Hardware Support" > > > + select ARM_SCMI_HAVE_SHMEM > > > help > > > Mailbox is a framework to control hardware communication between > > > on-chip processors through queued messages and interrupt driven > > > > > Isn't this too generic? > > Not all platforms, with a mailbox controller, use SCMI as the protocol. > > > > Yikes! I agree Jassi, this looks super hack. > Yes indeed, I have still to rework this part of the series. (@Jassi: I'm reworking this series starting from the work done by Peter up to V3, since it needed some core SCMI transport rework to ease implememtation of virtio-scmi transport) Thanks, Cristian > -- > Regards, > Sudeep