Hi Wesley, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.13-rc6 next-20210617] [cannot apply to balbi-usb/testing/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/94892083cf17e46a29d4ef33a044af04854162e6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Wesley-Cheng/Re-introduce-TX-FIFO-resize-for-larger-EP-bursting/20210617-180037 git checkout 94892083cf17e46a29d4ef33a044af04854162e6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_clear_tx_fifos': >> drivers/usb/dwc3/gadget.c:671:18: warning: variable 'dep' set but not used [-Wunused-but-set-variable] 671 | struct dwc3_ep *dep; | ^~~ -- drivers/usb/dwc3/gadget.c:648: warning: Function parameter or member 'mult' not described in 'dwc3_gadget_calc_tx_fifo_size' drivers/usb/dwc3/gadget.c:648: warning: Excess function parameter 'nfifos' description in 'dwc3_gadget_calc_tx_fifo_size' >> drivers/usb/dwc3/gadget.c:670: warning: expecting prototype for dwc3_gadget_clear_tx_fifo_size(). Prototype was for dwc3_gadget_clear_tx_fifos() instead vim +/dep +671 drivers/usb/dwc3/gadget.c 661 662 /** 663 * dwc3_gadget_clear_tx_fifo_size - Clears txfifo allocation 664 * @dwc: pointer to the DWC3 context 665 * 666 * Iterates through all the endpoint registers and clears the previous txfifo 667 * allocations. 668 */ 669 void dwc3_gadget_clear_tx_fifos(struct dwc3 *dwc) > 670 { > 671 struct dwc3_ep *dep; 672 int fifo_depth; 673 int size; 674 int num; 675 676 if (!dwc->do_fifo_resize) 677 return; 678 679 /* Read ep0IN related TXFIFO size */ 680 dep = dwc->eps[1]; 681 size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); 682 if (DWC3_IP_IS(DWC3)) 683 fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size); 684 else 685 fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size); 686 687 dwc->last_fifo_depth = fifo_depth; 688 /* Clear existing TXFIFO for all IN eps except ep0 */ 689 for (num = 3; num < min_t(int, dwc->num_eps, DWC3_ENDPOINTS_NUM); 690 num += 2) { 691 dep = dwc->eps[num]; 692 /* Don't change TXFRAMNUM on usb31 version */ 693 size = DWC3_IP_IS(DWC3) ? 0 : 694 dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1)) & 695 DWC31_GTXFIFOSIZ_TXFRAMNUM; 696 697 dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(num >> 1), size); 698 } 699 dwc->num_ep_resized = 0; 700 } 701 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
