On Thu, Jun 17, 2021 at 05:43:40PM +0800, Jamin Lin wrote: > Add i2c new driver to support new register set for AST2600. > AST2600 support three modes for data transfer which are > byte mode, buffer mode and dma mode, respectively. > The global driver of i2c is used to set the new register > mode and define the base clock frequency > of baseclk_1~baseclk_4. > > Signed-off-by: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx> > --- > drivers/i2c/busses/Kconfig | 11 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/ast2600-i2c-global.c | 205 +++ > drivers/i2c/busses/ast2600-i2c-global.h | 25 + > drivers/i2c/busses/i2c-new-aspeed.c | 1796 +++++++++++++++++++++++ I commented _something_ (but read comments carefully, they will cover much more). The overall it seems you have to: - shrink the code base by at least ~15% (it's possible), i.e. -200 LOCs - rethink how you do calculations and bit operations - better code style -- With Best Regards, Andy Shevchenko
