Hi Aswath, On 6/9/21 10:24 AM, Lokesh Vutla wrote: > > > On 09/06/21 8:52 pm, Aswath Govindraju wrote: >> Hi Lokesh, >> >> On 09/06/21 7:59 pm, Lokesh Vutla wrote: >>> >>> >>> On 07/06/21 7:08 pm, Aswath Govindraju wrote: >>>> Due to a limitation for USB DFU boot mode, SPL load address has to be less >>>> than or equal to 0x70001000. So, load address of SPL and ATF have been >>>> moved to 0x70000000 and 0x701a0000 respectively. >>>> >>>> Also, the maximum size of ATF has been increased to 0x1c000 [1]. >>>> >>>> Therefore, update ATF's location and maximum size accordingly in the device >>>> tree file. >>>> >>>> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9 >>>> >>>> Signed-off-by: Aswath Govindraju <a-govindraju@xxxxxx> >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> index ca59d1f711f8..fcd12b6f10f6 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> @@ -13,8 +13,8 @@ >>>> #size-cells = <1>; >>>> ranges = <0x0 0x00 0x70000000 0x200000>; >>>> >>>> - atf-sram@0 { >>>> - reg = <0x0 0x1a000>; >>>> + atf-sram@1a0000 { >>>> + reg = <0x1a0000 0x1c000>; >>> >>> After thinking a bot more, isn't size be 0x20000? >>> ATF is allocated with 125KB no? no point keeping the ~3 as hole IMO. >>> >> >> The max size of ATF as defined above in [1] is 0x1c000 and as the >> argument has to reflect it I have modified it to the same. > I personally prefer that the size increase and address relocation are split up into two separate patches for appropriate version compatibility. TFA 2.5 has updated the size to 0x1c000, so I would like to see that as the first patch. We should be able to merge that change right away. I see there is some on-going discussion around the relocated address, so it can fall in line with the corresponding SYSFW reservation patch. regards Suman > ahh..Got it. Ignore my comment. > > Thanks and regards, > Lokesh > >> >> Thanks, >> Aswath >> >> >>> Thanks and regards, >>> Lokesh >>> >>>> }; >>>> }; >>>> >>>> >>
