On 11-06-21, 18:31, Kishon Vijay Abraham I wrote: > >>> So there are a few users of max_link_rate. It would be better that we > >>> document all previous users of max_link_rate that unit is in Mbps and > >>> then modify it here > >>> > >> > >> I was able to see that the max_link_rate attribute was used at, > >> > >> drivers/phy/cadence/phy-cadence-torrent.c:2514: > >> gphy->attrs.max_link_rate = cdns_phy->max_bit_rate; > >> > >> and in the bindings there is indication that the units to be used is Mbps. > >> > >> Can you please point me if there is any other place that I might have > >> missed to look at or that might need documentation update? > >> > > The only user seems to be Torrent and max_bit_rate is documented well in > Torrent. > > Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx> Series Applied, thanks -- ~Vinod