Hi Geert,
Thank you for the patch.
On Thu, Jun 10, 2021 at 11:37:14AM +0200, Geert Uytterhoeven wrote:
> Document the compatible values for the R-Car H3e-2G (R8A779M1) and
> M3e-2G (R8A779M3) SoCs. These are different gradings of the R-Car H3
> ES3.0 (R8A77951) and M3-W+ (R8A77961) SoCs.
>
> All R-Car Gen3e on-SoC devices are identical to the devices on the
> corresponding R-Car Gen3 SoCs, and thus just use the compatible values
> for the latter. The root compatible properties do gain an additional
> value, to sort out integration issues if they ever arise.
>
> Document the use of these SoCs on the Salvator-XS and ULCB (with and
> without Kingfisher) development boards.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
(Copying a comment from another e-mail)
I however wonder if we haven't messed up the board compatible strings
somehow (unrelated to this patch). Aren't compatible strings supposed to
be ordered from most specific to most generic, with a more specific
compatible string being a strict subset of a more generic string ?
Looking at, for example,
compatible = "renesas,salvator-xs", "renesas,r8a779m1", "renesas,r8a7795";
the rule is upheld by renesas,r8a779m1 being a subset of the more
generic renesas,r8a7795, but that's not the case for
renesas,salvator-xs.
> ---
> .../devicetree/bindings/arm/renesas.yaml | 50 +++++++++++++++----
> 1 file changed, 39 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> index 5fd0696a9f91f383..a01dd064bf16632a 100644
> --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> @@ -238,17 +238,29 @@ properties:
> - const: renesas,r8a77961
>
> - description: Kingfisher (SBEV-RCAR-KF-M03)
> - items:
> - - const: shimafuji,kingfisher
> - - enum:
> - - renesas,h3ulcb
> - - renesas,m3ulcb
> - - renesas,m3nulcb
> - - enum:
> - - renesas,r8a7795
> - - renesas,r8a7796
> - - renesas,r8a77961
> - - renesas,r8a77965
> + oneOf:
> + - items:
> + - const: shimafuji,kingfisher
> + - enum:
> + - renesas,h3ulcb
> + - renesas,m3ulcb
> + - renesas,m3nulcb
> + - enum:
> + - renesas,r8a7795
> + - renesas,r8a7796
> + - renesas,r8a77961
> + - renesas,r8a77965
> + - items:
> + - const: shimafuji,kingfisher
> + - enum:
> + - renesas,h3ulcb
> + - renesas,m3ulcb
> + - enum:
> + - renesas,r8a779m1
> + - renesas,r8a779m3
> + - enum:
> + - renesas,r8a7795
> + - renesas,r8a77961
>
> - description: R-Car M3-N (R8A77965)
> items:
> @@ -296,6 +308,22 @@ properties:
> - const: renesas,falcon-cpu
> - const: renesas,r8a779a0
>
> + - description: R-Car H3e-2G (R8A779M1)
> + items:
> + - enum:
> + - renesas,h3ulcb # H3ULCB (R-Car Starter Kit Premier)
> + - renesas,salvator-xs # Salvator-XS (Salvator-X 2nd version)
> + - const: renesas,r8a779m1
> + - const: renesas,r8a7795
> +
> + - description: R-Car M3e-2G (R8A779M3)
> + items:
> + - enum:
> + - renesas,m3ulcb # M3ULCB (R-Car Starter Kit Pro)
> + - renesas,salvator-xs # Salvator-XS (Salvator-X 2nd version)
> + - const: renesas,r8a779m3
> + - const: renesas,r8a77961
> +
> - description: RZ/N1D (R9A06G032)
> items:
> - enum:
--
Regards,
Laurent Pinchart
