On Fri, Jun 11, 2021 at 10:59:07AM +0200, Jiří Prchal wrote: > > > On 11. 06. 21 10:48, Greg Kroah-Hartman wrote: > > On Fri, Jun 11, 2021 at 07:26:48AM +0200, Jiri Prchal wrote: > > > Added enum and string for FRAM to expose it as "fram". > > > > I have no idea what "FRAM" is, nor what "fram" is. > > > > And why do you not add the documentation update here in this same > > commit? This is where you are adding it, trying to dig later in the > > series to notice that you really did provide this is a pain, and is > > harder to track. > > > > Please provide more information here in the changelog and move the > > Documentation addition here into this patch. > > Should I also join #1 and 2 together? I do not remember what patch 2 is now, sorry. All you really need is the documentation update merged in here, I don't recall patch 2 being an issue. thanks, greg k-h