On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > Add compatible strings for pmm8155au_1 and pmm8155au_2 pmics > found on SA8155p-adp board. > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Liam Girdwood <lgirdwood@xxxxxxxxx> > Cc: Mark Brown <broonie@xxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Andy Gross <agross@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-gpio@xxxxxxxxxxxxxxx > Cc: bhupesh.linux@xxxxxxxxx > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > --- > .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > index e561a5b941e4..ea5cd71aa0c7 100644 > --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > @@ -55,6 +55,8 @@ properties: > - qcom,pm8009-1-rpmh-regulators > - qcom,pm8150-rpmh-regulators > - qcom,pm8150l-rpmh-regulators > + - qcom,pmm8155au-1-rpmh-regulators > + - qcom,pmm8155au-2-rpmh-regulators Looking at the component documentation and the schematics I think the component is "PMM8155AU" and we have two of them. Unless I'm mistaken we should have the compatible describe the single component and we should have DT describe the fact that we have 2 of them. Regards, Bjorn > - qcom,pm8350-rpmh-regulators > - qcom,pm8350c-rpmh-regulators > - qcom,pm8998-rpmh-regulators > -- > 2.31.1 >
