On Mon, Jul 21, 2014 at 9:32 PM, divya ojha <odivya77@xxxxxxxxx> wrote: > Hi, > > On Thu, Jul 17, 2014 at 8:55 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote: >> From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx> >> >> This is the pinctrl, pinmux, pinconf and gpiolib driver for the >> Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. >> >> Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx> >> --- >> drivers/pinctrl/Kconfig | 12 + >> drivers/pinctrl/Makefile | 1 + >> drivers/pinctrl/pinctrl-qpnp.c | 1565 +++++++++++++++++++++++++ >> include/dt-bindings/pinctrl/qcom,pm8xxx-mpp.h | 34 + > .. > + struct device *dev = qctrl->dev; >> + struct pinctrl_pin_desc *desc, *descs; >> + struct qpnp_padinfo *pad, *pads; >> + int idx, ret, cnt, gps, ais, aos, css; >> + const char **names, *format; >> + unsigned int addr; >> + >> + pads = devm_kcalloc(dev, qchip->npads, sizeof(*pads), GFP_KERNEL); > > when do we free these structures..? > devm_kmalloc is the function that is called in the end. Memory allocated with this API will be automatically released after device exit. Read http://lxr.free-electrons.com/source/drivers/base/devres.c#L774 for more. >> + if (!pads) >> + return -ENOMEM; >> + >> + descs = devm_kcalloc(dev, qchip->npads, sizeof(*descs), GFP_KERNEL); > > ditto.. > >> + if (!descs) >> + return -ENOMEM; >> + > .. >> + cnt = qctrl->groups[idx].npins; >> + if (!cnt) >> + continue; >> + >> + names = devm_kcalloc(dev, cnt, sizeof(names), GFP_KERNEL); > > ditto.. > >> + if (!names) >> + return -ENOMEM; > >> +#define PM8XXX_MPP_AIN_ABUS4 7 >> + >> +#endif >> -- >> 1.8.3.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Regards > Divya > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thanks and Regards Pramod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html