On Mon, Jun 07, 2021 at 04:47:44PM +0200, Jiří Prchal wrote: > > > On 07. 06. 21 14:36, Greg Kroah-Hartman wrote: > > On Mon, Jun 07, 2021 at 02:26:39PM +0200, Jiri Prchal wrote: > > > + return sysfs_emit(buf, "%016llx\n", *(unsigned long long *)at25->sernum); > > > > That's a horrid hack, why not use the %*phN modifier? > > Prints as little endian, is that OK? You tell me! What tool is going to be reading this? What do they expect it to look like? And it's a byte array, why would there be endian issues? thanks, greg k-h