On Thu, Jun 3, 2021 at 1:20 PM Steven Lee <steven_lee@xxxxxxxxxxxxxx> wrote:
>
> AST SoC supports *retain pin state* function when wdt reset.
> The patch adds set_config function for handling sgpio reset tolerance
> register.
...
> +static int aspeed_sgpio_set_config(struct gpio_chip *chip, unsigned int offset,
> + unsigned long config)
> +{
> + unsigned long param = pinconf_to_config_param(config);
> + u32 arg = pinconf_to_config_argument(config);
> +
> + if (param == PIN_CONFIG_PERSIST_STATE)
> + return aspeed_sgpio_reset_tolerance(chip, offset, arg);
> + else
Redundant.
> + return -EOPNOTSUPP;
IIRC we are using ENOTSUPP internally in the kernel. YEs, checkpatch
warning may be ignored.
> +}
--
With Best Regards,
Andy Shevchenko
