On Tue, Jun 1, 2021 at 10:39 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > On Mon, 31 May 2021, Robert Marko wrote: > > > Delta TN48M switches have a Lattice CPLD that serves > > multiple purposes including being a GPIO expander. > > > > So, lets use the simple I2C MFD driver to provide the MFD core. > > > > Also add a virtual symbol which pulls in the simple-mfd-i2c driver and > > provide a common symbol on which the subdevice drivers can depend on. > > > > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx> > > --- > > Changes in v2: > > * Drop the custom MFD driver and header > > * Use simple I2C MFD driver > > > > drivers/mfd/Kconfig | 10 ++++++++++ > > drivers/mfd/simple-mfd-i2c.c | 1 + > > 2 files changed, 11 insertions(+) > > I responded to a previous version of this. > > The question still remains - why do you need one single Regmap > encompassing all functionality. The register banks look separated to > me at first glance. Hi Lee, In the end, I replied to your v2 comments as well. It's quite extensive so I don't want to copy the replies here again. Is that okay, or should I copy the answers here as well? Regards, Robert > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@xxxxxxxxxx Web: www.sartura.hr
