Hello Arnd, On 18 July 2014 15:08, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote: >> This patchset support Exynos3250 ADC (Analog Digital Converter) because >> Exynos3250 has additional special clock for ADC IP. >> > > by coincidence, I have just looked at the same driver in order to > add support for s3c24xx and s3c64xx, so we can remove the plat-samsung > adc framework they still use. Those changes would naturally conflict > with yours, but I think it makes sense for your patches to come first. > > I'll comment a bit more on the individual patches. I didn't have > interest in them earlier, so I didn't comment so far. > > Another aspect that came up is the touchscreen support. Right now, > there is drivers/input/touchscreen/s3c2410_ts.c which is intimately > tied to arch/arm/plat-samsung/adc.c. The best way forward (as discussed > on IRC as few days ago) seems to be to integrate support for that into > the exynos_adc driver. Can you comment on which parts actually support > touchscreen? Did touchscreen support get dropped in the exynos hardware, > or is the driver just missing at the moment? SoCs from Samsung before Exynos4 had and ADC based Touch screen and the driver under arch/arm/plat-samsung/adc.c and drivers/input/touchscreen/s3c2410_ts.c used to work together. Infact, the interrupt routine and priorities in plat-samsung/adc.c driver as written keeping the Touchscreen in mind. After Exynos4, ADC IP remained. But, the touch screen was removed in hardware. As per suggestion from Doug Anderson, I've implemented IIO based ADC driver started to support from exynos5250. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
