On Fri, 04 Jul 2014, Javier Martinez Canillas wrote: > When platform data is not found an -EIO (I/O error) code is returned. > This doesn't seem to be the correct error so better return -EINVAL > (Invalid argument) which is what most drivers do in this case. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > --- > drivers/mfd/max77686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied now, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 12d4c17..ada4976 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -129,7 +129,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > > if (!pdata) { > dev_err(&i2c->dev, "No platform data found.\n"); > - return -EIO; > + return -EINVAL; > } > > max77686 = devm_kzalloc(&i2c->dev, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html