On 5/28/21 12:22 AM, Jan Kiszka wrote:
> On 28.05.21 07:09, Jan Kiszka wrote:
>> On 15.05.21 00:47, Suman Anna wrote:
>>> From: Roger Quadros <rogerq@xxxxxx>
>>>
>>> The ICSSGs on K3 AM65x SoCs contain an MDIO controller that can
>>> be used to control external PHYs associated with the Industrial
>>> Ethernet peripherals within each ICSSG instance. The MDIO module
>>> used within the ICSSG is similar to the MDIO Controller used
>>> in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the
>>> MDIO operations.
>>>
>>> The nodes are added and enabled in the common k3-am65-main.dtsi
>>> file by default, and disabled in the existing AM65 board dts
>>> files. These nodes need pinctrl lines, and so should be enabled
>>> only on boards where they are actually wired and pinned out for
>>> ICSSG Ethernet. Any new board dts file should disable these if
>>> they are not sure.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
>>> [s-anna@xxxxxx: move the disabled status to board dts files]
>>> Signed-off-by: Suman Anna <s-anna@xxxxxx>
>>> ---
>>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 12 ++++++++
>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 30 +++++++++++++++++++
>>> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++
>>> 3 files changed, 54 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>>> index de763ca9251c..63140eaba524 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>>> @@ -653,3 +653,15 @@ &pcie1_rc {
>>> &pcie1_ep {
>>> status = "disabled";
>>> };
>>> +
>>> +&icssg0_mdio {
>>> + status = "disabled";
>>> +};
>>> +
>>> +&icssg1_mdio {
>>> + status = "disabled";
>>> +};
>>> +
>>> +&icssg2_mdio {
>>> + status = "disabled";
>>> +};
>>
>> We will need this here for PRU networking. What would be the impact of
>> leaving it enabled already at this stage?
>>
>
> Ah, now reading our backlog completely - there will be more coming in to
> this file than not disabling icssg mdio (and that only for mdio0). So:
Yeah, these will be enabled when the corresponding pinctrl pins are added, so
will come alongside the icssg ethernet nodes in the future.
>
> Acked-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>
> Jan
>
> PS: How far are we away from icssg-prueth?
The last missing pieces from PRUSS foundation point of view are the PRUSS
consumer API series, which need next versions to be posted upstream. I would say
still couple of merge windows.
regards
Suman
