On Tue, 25 May 2021 at 11:05, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Tue, 25 May 2021 at 07:39, Anup Patel <anup@xxxxxxxxxxxxxx> wrote: > > > > On Mon, May 24, 2021 at 11:31 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > > > > > On Mon, 17 May 2021 at 15:10, Anup Patel <anup.patel@xxxxxxx> wrote: > > > > > > > > The generic power domain related code in PSCI domain driver is largely > > > > independent of PSCI and can be shared with RISC-V SBI domain driver > > > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > > > > > Signed-off-by: Anup Patel <anup.patel@xxxxxxx> > > > > > > This is clearly a big step in the right direction. Just a couple minor > > > things, see more below. > > > > > > Note that, I have a couple of patches in the pipe for the > > > cpuidle-psci-domain driver (not ready to be posted). I need a couple > > > of more days to confirm this restructuring still makes sense beyond > > > these potential new changes. I will let you know as soon as I can with > > > the outcome. > > > > Sure, I will wait for more comments from you. I was thinking of sending > > next revision of patches sometime next week with the renaming of > > function names which you suggested. > > Sounds good, that allows me a few more days this week. I don't have any further comments at this point. It looks good to me, but let me have a quick review on the next version before I provide my ack. [...] Kind regards Uffe
