Re: [PATCH v3 5/6] pinctrl: Add RTL8231 pin control and GPIO support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 2021-05-28 08:42, schrieb Sander Vanheule:
On Fri, 2021-05-28 at 08:29 +0200, Michael Walle wrote:
> +       gpio_cfg.reg_dat_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0);
> +       gpio_cfg.reg_set_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0);
> +       gpio_cfg.reg_dir_in_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DIR0);

Btw. you'd only need GPIO_REGMAP_ADDR(x) if x might be 0. Because you
have
a constant != 0 there, you could save the GPIO_REGMAP_ADDR() call. You
could drop this if you like, but no need to respin the series for this.

I will need to respin this series anyway, so I can drop the GPIO_REGMAP_ADDR() calls. I was aware they are no-ops in this case, as register address 0 is not used for the GPIO functions, so mainly included them as a form of documentation.

It's up to you if you like to change it or keep it.

-michael



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux