On Thu, May 27, 2021 at 02:04:30PM -0700, Saravana Kannan wrote: > On Thu, May 27, 2021 at 1:09 AM Orson Zhai <orsonzhai@xxxxxxxxx> wrote: > > > > From: Orson Zhai <orson.zhai@xxxxxxxxxx> > > > > pwms is often required by backlight in embedded devices. Add device link > > support for pwms as well. > > > > Signed-off-by: Orson Zhai <orson.zhai@xxxxxxxxxx> > > --- > > drivers/of/property.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index 6c02863..93be977 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -1287,6 +1287,7 @@ DEFINE_SIMPLE_PROP(pinctrl6, "pinctrl-6", NULL) > > DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL) > > DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL) > > DEFINE_SIMPLE_PROP(remote_endpoint, "remote-endpoint", NULL) > > +DEFINE_SIMPLE_PROP(pwms, "pwms", NULL) > > DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) > > DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") > > > > @@ -1371,6 +1372,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { > > { .parse_prop = parse_pinctrl7, }, > > { .parse_prop = parse_pinctrl8, }, > > { .parse_prop = parse_remote_endpoint, .node_not_dev = true, }, > > + { .parse_prop = parse_pwms, }, > > { .parse_prop = parse_gpio_compat, }, > > { .parse_prop = parse_interrupts, }, > > { .parse_prop = parse_regulators, }, > > I already have a local patch for this and "reset" bindings. But I'm > holding off on adding support for new properties till fw_devlink=on > fully lands in 5.13. Trying to avoid inadvertently adding new > dependency issues. For example, the remote_endpoint binding I added to > fix one issue caused more dependency issues. So far I've fixed them > all. Got it. Good to know your plan. > > So, yeah, temporary Nak for this. No problem. -Orson > > -Saravana