On Mon, 24 May 2021, Rob Herring wrote: > On Mon, May 24, 2021 at 02:05:38PM +0200, Robert Marko wrote: > > Add binding documents for the Delta TN48M CPLD drivers. > > > > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx> > > --- > > Changes in v2: > > * Implement MFD as a simple I2C MFD > > * Add GPIO bindings as separate > > I don't understand why this changed. This doesn't look like an MFD to > me. Make your binding complete if there are missing functions. > Otherwise, stick with what I already ok'ed. Right. What else, besides GPIO, does this do? > > .../bindings/gpio/delta,tn48m-gpio.yaml | 42 ++++++++++ > > .../bindings/mfd/delta,tn48m-cpld.yaml | 81 +++++++++++++++++++ > > 2 files changed, 123 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml > > create mode 100644 Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog