On 5/24/21 4:02 PM, kernel test robot wrote: > Hi Randy, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on robh/for-next] > [also build test ERROR on linux/master linus/master v5.13-rc3 next-20210524] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Randy-Dunlap/OF-of_address-clean-up-OF-stub-extern-functions/20210525-031115 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > config: s390-randconfig-r001-20210524 (attached as .config) > compiler: s390-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/8a9c54f1437e3af04c6de3b9606b46437ea69a12 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Randy-Dunlap/OF-of_address-clean-up-OF-stub-extern-functions/20210525-031115 > git checkout 8a9c54f1437e3af04c6de3b9606b46437ea69a12 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> Yes, this patch wasn't expected to fix all of these arch/s390/ build errors. Before this patch: (9 undefined symbols) ERROR: modpost: "devm_ioremap_resource" [drivers/crypto/ccree/ccree.ko] undefined! ERROR: modpost: "debugfs_create_regset32" [drivers/crypto/ccree/ccree.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/media/rc/ir-hix5hd2.ko] undefined! ERROR: modpost: "ioremap" [drivers/pcmcia/pcmcia.ko] undefined! ERROR: modpost: "iounmap" [drivers/pcmcia/pcmcia.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/dma/qcom/hdma.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/dma/qcom/hdma_mgmt.ko] undefined! ERROR: modpost: "of_address_to_resource" [drivers/dma/qcom/hdma_mgmt.ko] undefined! This patch only affected the last symbol above. And it covers of_iomap() in my build testing as well. After this patch: (8 undefined symbols) > All errors (new ones prefixed by >>, old ones prefixed by <<): > > ERROR: modpost: "devm_ioremap_resource" [drivers/crypto/ccree/ccree.ko] undefined! > ERROR: modpost: "debugfs_create_regset32" [drivers/crypto/ccree/ccree.ko] undefined! > ERROR: modpost: "devm_ioremap_resource" [drivers/media/rc/ir-hix5hd2.ko] undefined! > ERROR: modpost: "ioremap" [drivers/pcmcia/pcmcia.ko] undefined! > ERROR: modpost: "iounmap" [drivers/pcmcia/pcmcia.ko] undefined! >>> ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! > ERROR: modpost: "devm_ioremap_resource" [drivers/dma/qcom/hdma.ko] undefined! > ERROR: modpost: "devm_ioremap_resource" [drivers/dma/qcom/hdma_mgmt.ko] undefined! I think that all of these arch/s390/ builds undefined symbols when CONFIG_HAS_IOMEM is not set are low priority (or no priority) for most people. -- ~Randy
