Re: [PATCH 6/6] extcon: sm5502: Add support for SM5504

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stephan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on chanwoo-extcon/extcon-next]
[also build test WARNING on robh/for-next linus/master v5.13-rc2 next-20210521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stephan-Gerhold/extcon-sm5502-Add-support-for-SM5504/20210522-215255
base:   https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git extcon-next
config: x86_64-randconfig-b001-20210522 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e84a9b9bb3051c35dea993cdad7b3d2575638f85)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/f9928587360c40e166418ea5b10fc0c210b93330
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stephan-Gerhold/extcon-sm5502-Add-support-for-SM5504/20210522-215255
        git checkout f9928587360c40e166418ea5b10fc0c210b93330
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/extcon/extcon-sm5502.c:696:15: warning: cast to smaller integer type 'enum sm5502_types' from 'const void *' [-Wvoid-pointer-to-enum-cast]
           info->type = (enum sm5502_types)device_get_match_data(info->dev);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +696 drivers/extcon/extcon-sm5502.c

914b881f9452fd Chanwoo Choi     2014-05-22  677  
9e92a019f01894 Stephan Gerhold  2021-05-20  678  static int sm5022_muic_i2c_probe(struct i2c_client *i2c)
914b881f9452fd Chanwoo Choi     2014-05-22  679  {
914b881f9452fd Chanwoo Choi     2014-05-22  680  	struct device_node *np = i2c->dev.of_node;
f9928587360c40 Stephan Gerhold  2021-05-20  681  	const struct regmap_irq_chip *irq_chip;
914b881f9452fd Chanwoo Choi     2014-05-22  682  	struct sm5502_muic_info *info;
914b881f9452fd Chanwoo Choi     2014-05-22  683  	int i, ret, irq_flags;
914b881f9452fd Chanwoo Choi     2014-05-22  684  
914b881f9452fd Chanwoo Choi     2014-05-22  685  	if (!np)
914b881f9452fd Chanwoo Choi     2014-05-22  686  		return -EINVAL;
914b881f9452fd Chanwoo Choi     2014-05-22  687  
914b881f9452fd Chanwoo Choi     2014-05-22  688  	info = devm_kzalloc(&i2c->dev, sizeof(*info), GFP_KERNEL);
914b881f9452fd Chanwoo Choi     2014-05-22  689  	if (!info)
914b881f9452fd Chanwoo Choi     2014-05-22  690  		return -ENOMEM;
914b881f9452fd Chanwoo Choi     2014-05-22  691  	i2c_set_clientdata(i2c, info);
914b881f9452fd Chanwoo Choi     2014-05-22  692  
914b881f9452fd Chanwoo Choi     2014-05-22  693  	info->dev = &i2c->dev;
914b881f9452fd Chanwoo Choi     2014-05-22  694  	info->i2c = i2c;
914b881f9452fd Chanwoo Choi     2014-05-22  695  	info->irq = i2c->irq;
f9928587360c40 Stephan Gerhold  2021-05-20 @696  	info->type = (enum sm5502_types)device_get_match_data(info->dev);
f9928587360c40 Stephan Gerhold  2021-05-20  697  
f9928587360c40 Stephan Gerhold  2021-05-20  698  	switch (info->type) {
f9928587360c40 Stephan Gerhold  2021-05-20  699  	case TYPE_SM5502:
f9928587360c40 Stephan Gerhold  2021-05-20  700  		irq_chip = &sm5502_muic_irq_chip;
914b881f9452fd Chanwoo Choi     2014-05-22  701  		info->muic_irqs = sm5502_muic_irqs;
914b881f9452fd Chanwoo Choi     2014-05-22  702  		info->num_muic_irqs = ARRAY_SIZE(sm5502_muic_irqs);
914b881f9452fd Chanwoo Choi     2014-05-22  703  		info->reg_data = sm5502_reg_data;
914b881f9452fd Chanwoo Choi     2014-05-22  704  		info->num_reg_data = ARRAY_SIZE(sm5502_reg_data);
f9928587360c40 Stephan Gerhold  2021-05-20  705  		break;
f9928587360c40 Stephan Gerhold  2021-05-20  706  	case TYPE_SM5504:
f9928587360c40 Stephan Gerhold  2021-05-20  707  		irq_chip = &sm5504_muic_irq_chip;
f9928587360c40 Stephan Gerhold  2021-05-20  708  		info->muic_irqs = sm5504_muic_irqs;
f9928587360c40 Stephan Gerhold  2021-05-20  709  		info->num_muic_irqs = ARRAY_SIZE(sm5504_muic_irqs);
f9928587360c40 Stephan Gerhold  2021-05-20  710  		info->reg_data = sm5504_reg_data;
f9928587360c40 Stephan Gerhold  2021-05-20  711  		info->num_reg_data = ARRAY_SIZE(sm5504_reg_data);
f9928587360c40 Stephan Gerhold  2021-05-20  712  		break;
f9928587360c40 Stephan Gerhold  2021-05-20  713  	default:
f9928587360c40 Stephan Gerhold  2021-05-20  714  		return -EINVAL;
f9928587360c40 Stephan Gerhold  2021-05-20  715  	}
914b881f9452fd Chanwoo Choi     2014-05-22  716  
914b881f9452fd Chanwoo Choi     2014-05-22  717  	mutex_init(&info->mutex);
914b881f9452fd Chanwoo Choi     2014-05-22  718  
914b881f9452fd Chanwoo Choi     2014-05-22  719  	INIT_WORK(&info->irq_work, sm5502_muic_irq_work);
914b881f9452fd Chanwoo Choi     2014-05-22  720  
914b881f9452fd Chanwoo Choi     2014-05-22  721  	info->regmap = devm_regmap_init_i2c(i2c, &sm5502_muic_regmap_config);
914b881f9452fd Chanwoo Choi     2014-05-22  722  	if (IS_ERR(info->regmap)) {
914b881f9452fd Chanwoo Choi     2014-05-22  723  		ret = PTR_ERR(info->regmap);
914b881f9452fd Chanwoo Choi     2014-05-22  724  		dev_err(info->dev, "failed to allocate register map: %d\n",
914b881f9452fd Chanwoo Choi     2014-05-22  725  				   ret);
914b881f9452fd Chanwoo Choi     2014-05-22  726  		return ret;
914b881f9452fd Chanwoo Choi     2014-05-22  727  	}
914b881f9452fd Chanwoo Choi     2014-05-22  728  
914b881f9452fd Chanwoo Choi     2014-05-22  729  	/* Support irq domain for SM5502 MUIC device */
914b881f9452fd Chanwoo Choi     2014-05-22  730  	irq_flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT | IRQF_SHARED;
f9928587360c40 Stephan Gerhold  2021-05-20  731  	ret = devm_regmap_add_irq_chip(info->dev, info->regmap, info->irq,
f9928587360c40 Stephan Gerhold  2021-05-20  732  				       irq_flags, 0, irq_chip, &info->irq_data);
914b881f9452fd Chanwoo Choi     2014-05-22  733  	if (ret != 0) {
914b881f9452fd Chanwoo Choi     2014-05-22  734  		dev_err(info->dev, "failed to request IRQ %d: %d\n",
914b881f9452fd Chanwoo Choi     2014-05-22  735  				    info->irq, ret);
914b881f9452fd Chanwoo Choi     2014-05-22  736  		return ret;
914b881f9452fd Chanwoo Choi     2014-05-22  737  	}
914b881f9452fd Chanwoo Choi     2014-05-22  738  
914b881f9452fd Chanwoo Choi     2014-05-22  739  	for (i = 0; i < info->num_muic_irqs; i++) {
914b881f9452fd Chanwoo Choi     2014-05-22  740  		struct muic_irq *muic_irq = &info->muic_irqs[i];
363b389106e676 Andrzej Hajda    2015-09-24  741  		int virq = 0;
914b881f9452fd Chanwoo Choi     2014-05-22  742  
914b881f9452fd Chanwoo Choi     2014-05-22  743  		virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq);
914b881f9452fd Chanwoo Choi     2014-05-22  744  		if (virq <= 0)
914b881f9452fd Chanwoo Choi     2014-05-22  745  			return -EINVAL;
914b881f9452fd Chanwoo Choi     2014-05-22  746  		muic_irq->virq = virq;
914b881f9452fd Chanwoo Choi     2014-05-22  747  
914b881f9452fd Chanwoo Choi     2014-05-22  748  		ret = devm_request_threaded_irq(info->dev, virq, NULL,
914b881f9452fd Chanwoo Choi     2014-05-22  749  						sm5502_muic_irq_handler,
005ad18727b489 Vasyl Gomonovych 2019-07-19  750  						IRQF_NO_SUSPEND | IRQF_ONESHOT,
914b881f9452fd Chanwoo Choi     2014-05-22  751  						muic_irq->name, info);
914b881f9452fd Chanwoo Choi     2014-05-22  752  		if (ret) {
fbae30d8dd3545 Chanwoo Choi     2014-08-12  753  			dev_err(info->dev,
fbae30d8dd3545 Chanwoo Choi     2014-08-12  754  				"failed: irq request (IRQ: %d, error :%d)\n",
fbae30d8dd3545 Chanwoo Choi     2014-08-12  755  				muic_irq->irq, ret);
914b881f9452fd Chanwoo Choi     2014-05-22  756  			return ret;
914b881f9452fd Chanwoo Choi     2014-05-22  757  		}
914b881f9452fd Chanwoo Choi     2014-05-22  758  	}
914b881f9452fd Chanwoo Choi     2014-05-22  759  
914b881f9452fd Chanwoo Choi     2014-05-22  760  	/* Allocate extcon device */
914b881f9452fd Chanwoo Choi     2014-05-22  761  	info->edev = devm_extcon_dev_allocate(info->dev, sm5502_extcon_cable);
914b881f9452fd Chanwoo Choi     2014-05-22  762  	if (IS_ERR(info->edev)) {
914b881f9452fd Chanwoo Choi     2014-05-22  763  		dev_err(info->dev, "failed to allocate memory for extcon\n");
914b881f9452fd Chanwoo Choi     2014-05-22  764  		return -ENOMEM;
914b881f9452fd Chanwoo Choi     2014-05-22  765  	}
914b881f9452fd Chanwoo Choi     2014-05-22  766  
914b881f9452fd Chanwoo Choi     2014-05-22  767  	/* Register extcon device */
914b881f9452fd Chanwoo Choi     2014-05-22  768  	ret = devm_extcon_dev_register(info->dev, info->edev);
914b881f9452fd Chanwoo Choi     2014-05-22  769  	if (ret) {
914b881f9452fd Chanwoo Choi     2014-05-22  770  		dev_err(info->dev, "failed to register extcon device\n");
914b881f9452fd Chanwoo Choi     2014-05-22  771  		return ret;
914b881f9452fd Chanwoo Choi     2014-05-22  772  	}
914b881f9452fd Chanwoo Choi     2014-05-22  773  
e1954452f500cb Chanwoo Choi     2014-05-28  774  	/*
e1954452f500cb Chanwoo Choi     2014-05-28  775  	 * Detect accessory after completing the initialization of platform
e1954452f500cb Chanwoo Choi     2014-05-28  776  	 *
e1954452f500cb Chanwoo Choi     2014-05-28  777  	 * - Use delayed workqueue to detect cable state and then
e1954452f500cb Chanwoo Choi     2014-05-28  778  	 * notify cable state to notifiee/platform through uevent.
e1954452f500cb Chanwoo Choi     2014-05-28  779  	 * After completing the booting of platform, the extcon provider
e1954452f500cb Chanwoo Choi     2014-05-28  780  	 * driver should notify cable state to upper layer.
e1954452f500cb Chanwoo Choi     2014-05-28  781  	 */
e1954452f500cb Chanwoo Choi     2014-05-28  782  	INIT_DELAYED_WORK(&info->wq_detcable, sm5502_muic_detect_cable_wq);
e1954452f500cb Chanwoo Choi     2014-05-28  783  	queue_delayed_work(system_power_efficient_wq, &info->wq_detcable,
e1954452f500cb Chanwoo Choi     2014-05-28  784  			msecs_to_jiffies(DELAY_MS_DEFAULT));
e1954452f500cb Chanwoo Choi     2014-05-28  785  
914b881f9452fd Chanwoo Choi     2014-05-22  786  	/* Initialize SM5502 device and print vendor id and version id */
914b881f9452fd Chanwoo Choi     2014-05-22  787  	sm5502_init_dev_type(info);
914b881f9452fd Chanwoo Choi     2014-05-22  788  
914b881f9452fd Chanwoo Choi     2014-05-22  789  	return 0;
914b881f9452fd Chanwoo Choi     2014-05-22  790  }
914b881f9452fd Chanwoo Choi     2014-05-22  791  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux