On Fri 21 May 05:27 CDT 2021, Krishna Manikandan wrote: > Add YAML schema for the device tree bindings for DSI PHY. > > Signed-off-by: Krishna Manikandan <mkrishn@xxxxxxxxxxxxxx> > > Changes in v1: > - Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd) > - Remove qcom,dsi-phy-regulator-ldo-mode (Stephen Boyd) > - Add clock cells properly (Stephen Boyd) > - Remove unnecessary decription from clock names (Stephen Boyd) > - Add pin names for the supply entries for 10nm phy which is > used in sc7180 and sdm845 (Stephen Boyd) > - Remove unused header files from examples (Stephen Boyd) > - Drop labels for display nodes and correct node name (Stephen Boyd) > > Changes in v2: > - Drop maxItems for clock (Stephen Boyd) > - Add vdds supply pin information for sdm845 (Stephen Boyd) > - Add examples for 14nm, 20nm and 28nm phy yaml files (Stephen Boyd) > - Keep child nodes directly under soc node (Stephen Boyd) > > Changes in v3: > - Use a separate yaml file to describe the common properties > for all the dsi phy versions (Stephen Boyd) > - Remove soc from examples (Stephen Boyd) > - Add description for register property > > Changes in v4: > - Modify the title for all the phy versions (Stephen Boyd) > - Drop description for all the phy versions (Stephen Boyd) > - Modify the description for register property (Stephen Boyd) > > Changes in v5: > - Remove unused properties from common dsi phy file > - Add clock-cells and phy-cells to required property > list (Stephen Boyd) > > Changes in v6: > - Add proper compatible string in example > --- > .../bindings/display/msm/dsi-phy-10nm.yaml | 68 +++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-14nm.yaml | 66 ++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-20nm.yaml | 71 ++++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-28nm.yaml | 68 +++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-common.yaml | 40 ++++++++++++ > 5 files changed, 313 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > new file mode 100644 > index 0000000..4a26bef > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/dsi-phy-10nm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Display DSI 10nm PHY > + > +maintainers: > + - Krishna Manikandan <mkrishn@xxxxxxxxxxxxxx> > + > +allOf: > + - $ref: dsi-phy-common.yaml# > + > +properties: > + compatible: > + oneOf: > + - const: qcom,dsi-phy-10nm > + - const: qcom,dsi-phy-10nm-8998 > + > + reg: > + items: > + - description: dsi phy register set > + - description: dsi phy lane register set > + - description: dsi pll register set > + > + reg-names: > + items: > + - const: dsi_phy > + - const: dsi_phy_lane > + - const: dsi_pll > + > + vdds-supply: > + description: | > + Connected to DSI0_MIPI_DSI_PLL_VDDA0P9 pin for sc7180 target and > + connected to VDDA_MIPI_DSI_0_PLL_0P9 pin for sdm845 target "Reference to the 0.9V supply for the PLL." would have been sufficient. But overall I think the patch looks good. Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> Regards, Bjorn
