On Wed, May 19, 2021 at 08:06:46PM +0530, Bhupesh Sharma wrote: > Add the missing required property - 'iommus' to the > device-tree binding documentation for qcom-bam DMA IP. > > This property describes the phandle(s) to apps_smmu node with sid mask. > > Cc: Thara Gopinath <thara.gopinath@xxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Andy Gross <agross@xxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > Cc: Stephen Boyd <sboyd@xxxxxxxxxx> > Cc: Michael Turquette <mturquette@xxxxxxxxxxxx> > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > Cc: dmaengine@xxxxxxxxxxxxxxx > Cc: linux-clk@xxxxxxxxxxxxxxx > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: bhupesh.linux@xxxxxxxxx > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > --- > .../devicetree/bindings/dma/qcom_bam_dma.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > index d2900616006c..2479862a3654 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > @@ -55,6 +55,12 @@ properties: > interconnect-names: > const: memory > > + iommus: > + minItems: 1 > + maxItems: 8 > + description: | > + phandle to apps_smmu node with sid mask. And what are the other 7 entries? > + > qcom,ee: > $ref: /schemas/types.yaml#/definitions/uint8 > description: > @@ -81,6 +87,7 @@ required: > - clocks > - clock-names > - "#dma-cells" > + - iommus > - qcom,ee > > additionalProperties: false > @@ -96,4 +103,8 @@ examples: > clock-names = "bam_clk"; > #dma-cells = <1>; > qcom,ee = /bits/ 8 <0>; > + iommus = <&apps_smmu 0x584 0x0011>, > + <&apps_smmu 0x586 0x0011>, > + <&apps_smmu 0x594 0x0011>, > + <&apps_smmu 0x596 0x0011>; > }; > -- > 2.31.1 >
