Hi Tomasz, On Wed, Jul 16, 2014 at 4:25 PM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > Hi Abhilash, > > Please see my comments inline. Also CCing some DT maintainers. > > On 15.07.2014 20:34, Abhilash Kesavan wrote: >> PPMU is required by the exynos5250 devfreq driver. Add a device >> tree node for it. >> >> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx> >> --- >> .../bindings/arm/exynos/ppmu-exynos5.txt | 26 ++++++++++++++++++++ >> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/exynos/ppmu-exynos5.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/exynos/ppmu-exynos5.txt b/Documentation/devicetree/bindings/arm/exynos/ppmu-exynos5.txt >> new file mode 100644 >> index 0000000..a6a2eba >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/exynos/ppmu-exynos5.txt >> @@ -0,0 +1,26 @@ >> +Exynos PPMU driver >> +------------------- >> + >> +Performance events are primitive values used to get performance data. These >> +events provide information about the behavior of the SoC that can be used >> +when analyzing system performance. These events are made visible using the >> +PPMU logic. >> +Exynos PPMU driver is used by the exynos5 devfreq drivers to control the >> +bus frequency/voltage. >> + >> +Required properties: >> +- compatible: "samsung,exynos5250-int-busfreq", "samsung,exynos5420-int-busfreq" > > If this is a binding for PPMU, shouldn't the compatible string contain > the "ppmu" string too? E.g. "samsung,exynos5250-ppmu", > "samsung,exynos5420-ppmu". > >> +- reg: >> + * physical base address of the PPMUs (e.g DDR, Right Bus, Left bus etc) >> + and length of memory mapped region. > > Since PPMU are separate IP blocks, they should have their own device > nodes with only address ranges of their own. Representing all PPMUs in > the SoC with a single node is incorrect. OK, I will re-work this. > > Best regards, > Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
