On Sun, 2021-05-16 at 23:40 +0200, Sander Vanheule wrote: > > 2. Please, switch to fwnode API in LED driver > > Since you had the same comment on my previous patch set, I had already tried to > this this into account as much as possible. > > There's a few things I couldn't find the fwnode-equivalent for: > * I use of_node_name_prefix to enforce the naming required by the binding. I > could just walk over all (available) child nodes, which would be mostly > equivalent. > * To get the address of an LED child node, I use of_get_address, since this > appeared to provide what I want to do: get the address of the node. I know > next to nothing about ACPI. Does the equivalent exist there? Or am I taking > the wrong approach? Hi Andy, I found this: https://www.kernel.org/doc/html/latest/firmware-guide/acpi/dsd/leds.html So instead of of_address, I now just read the "reg" property. The v2 I just sent should be fwnode-only. Best, Sander
