Re: [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture begin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 14, 2021 at 12:20:46PM +0530, Srinivasa Rao Mandadapu wrote:
> On 5/13/2021 7:01 PM, Mark Brown wrote:

> > This commit doesn't remove the matching update in triger() so we'd have
> > two redundant updates.  I guess it's unlikely to be harmful but it looks
> > wrong/confusing.

> Yes, It's not harmful, as clk_prepare_enable is enabling clock only once but
> maintaining count.

> As Some times in Suspend/resume Sequence not hitting startup/shutdown, but
> Trigger, so for maintaining

> consistency not removed in trigger.

This at least needs some commenting so that it's clear, it looks buggy
at the minute.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux