On Tue, May 11, 2021 at 09:51:00AM +0100, Rui Miguel Silva wrote: > The nxp,isp1760 driver is old in the tree, but did not had a bindings > entry, since I am extend it to support isp1763 in the same family, use > this to add a proper yaml bindings file. > > Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx> > --- > .../devicetree/bindings/usb/nxp,isp1760.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > > diff --git a/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml b/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > new file mode 100644 > index 000000000000..0d76529e9662 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/nxp,isp1760.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP ISP1760 family controller bindings > + > +maintainers: > + - Sebastian Siewior <bigeasy@xxxxxxxxxxxxx> > + - Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > + > +description: | > + NXP ISP1760 family, which includes ISP1760/1761/1763 devicetree controller > + bindings > + > +properties: > + compatible: > + enum: > + - nxp,usb-isp1760 > + - nxp,usb-isp1761 > + - nxp,usb-isp1763 > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 In the 1761 datasheet, looks like there's a separate host and device irq. > + > + bus-width: > + description: > + Number of data lines. > + enum: [8, 16, 32] > + default: 32 > + > + dr_mode: > + enum: > + - host > + - peripheral > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: true Like what? 'true' is only correct for common collections of properties. > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + usb@40200000 { > + compatible = "nxp,usb-isp1763"; > + reg = <0x40200000 0x100000>; > + interrupts-parent = <&gic>; > + interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>; > + bus-width = <16>; > + dr_mode = "host"; > + }; > + > +... > -- > 2.31.1 >
