Hi Arnd, On Wed, Jul 16, 2014 at 10:39:36AM +0200, Arnd Bergmann wrote: > On Wednesday 16 July 2014 10:26:02 Antoine Ténart wrote: > > + > > +Required properties: > > +- compatible: should be "chipidea,usb2" > > +- reg: base address and length of the registers > > +- interrupts: interrupt for the USB controller > > + > > +Optional properties: > > +- clocks: reference to the USB clock > > +- usb-phy: reference to the USB PHY > > I think the phy reference should use the standard phy binding, using > "phys" property to refer to a node that has a "#phy-cells" property. > > It seems the code gets this right, but just the documentation is wrong. I moved this PHY driver from usb/phy/ to phy/ and forgot to update this property. I'll fix it. > > > +- vbus-supply: reference to the VBUS regulator > > +- dma-mask: DMA bit mask > > No. Do not use "dma-mask" as a property, that is a pure Linux specific > concept. The DT way to express this is to use the 'dma-ranges' property > in the device's parent to describe any bus-related restrictions, and > for the driver to ask for a mask that matches what the hardware is > capable of (which may be smaller or larger than what the bus supports). Ok. I'll answer in the CI driver's thread. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
