On Fri, Apr 16, 2021 at 9:30 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
>
> On Fri, Apr 16, 2021 at 12:37 AM Enric Balletbo Serra
> <eballetbo@xxxxxxxxx> wrote:
> >
> > Hi Ikjoon,
> >
> > Thank you for your patch.
> >
> > Missatge de Ikjoon Jang <ikjn@xxxxxxxxxxxx> del dia dj., 15 d’abr.
> > 2021 a les 5:32:
> > >
> > > This is for ChromeOS tablets which have a 'cros_cbas' switch device
> > > in the "Whiskers" base board. This device can be instantiated only by
> > > device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> > > probe the device.
> > >
> > > Signed-off-by: Ikjoon Jang <ikjn@xxxxxxxxxxxx>
> > >
> > > ---
> > >
> > > Changes in v5:
> > > - Add missing blank lines and change the description property's position.
> > > - Add a note to description: "this device cannot be detected at runtime."
> > >
> > > Changes in v4:
> > > Define cros-cbase bindings inside google,cros-ec.yaml instead of
> > > a separated binding document.
> > >
> > > .../bindings/mfd/google,cros-ec.yaml | 20 +++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > index 76bf16ee27ec..8dcce176b72e 100644
> > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > @@ -114,6 +114,22 @@ properties:
> > > - "#address-cells"
> > > - "#size-cells"
> > >
> > > + cbas:
> > > + type: object
> > > +
> > > + description:
> > > + This device is used to signal when a detachable base is attached
> > > + to a Chrome OS tablet. This device cannot be detected at runtime.
> > > +
> > > + properties:
> > > + compatible:
> > > + const: google,cros-cbas
> > > +
> > > + required:
> > > + - compatible
> > > +
> > > + additionalProperties: false
> > > +
> > > patternProperties:
> > > "^i2c-tunnel[0-9]*$":
> > > type: object
> > > @@ -180,6 +196,10 @@ examples:
> > > interrupts = <99 0>;
> > > interrupt-parent = <&gpio7>;
> > > spi-max-frequency = <5000000>;
> > > +
> > > + base_detection: cbas {
> >
> > nit: Rob, shouldn't this be just cbas?
>
> Yes.
Sorry, I'm a bit confused here.
'base_detection: cbas' in example should be just 'cbas'?
Maybe that's because cbas doesn't need to have a phandle or just by
its definition in schema?
Please let me upload v6 if this needs to be fixed.
Thanks for reviewing!
>
> >
> > > + compatible = "google,cros-cbas";
> > > + };
> > > };
> > > };
> > >
> > > --
> > > 2.31.1.295.g9ea45b61b8-goog
> > >
> >
> > Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
