On Mon, May 10, 2021 at 09:48:48PM +0200, Ondřej Jirman wrote:
> On Mon, May 10, 2021 at 09:31:08PM +0200, Stephan Gerhold wrote:
> > + tsdata->iovcc = devm_regulator_get(&client->dev, "iovcc");
> > + if (IS_ERR(tsdata->iovcc)) {
> > + error = PTR_ERR(tsdata->iovcc);
> > + if (error != -EPROBE_DEFER)
> > + dev_err(&client->dev,
> > + "failed to request iovcc regulator: %d\n", error);
>
> Please use dev_err_probe instead. If this pattern is used for vcc-supply, maybe
> change that too. Maybe also consider using a bulk regulator API.
Dmitry seems is having something against it last time I remember it was
discussed with him.
--
With Best Regards,
Andy Shevchenko
