Hello Shawn, digging through my mailbox of unarchived mails I found this patch. On Sat, Aug 22, 2020 at 08:56:12PM +0800, Shawn Guo wrote: > On Mon, Aug 10, 2020 at 10:47:25AM +0200, Uwe Kleine-König wrote: > > The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as > > Is this how i.MX25 RM names the function? The reference manual (Rev. 2; 01/2011) doesn't give a name. The relevant description for the GPIO_A pad reads: MUX Mode Select Field. Select 1 of 7 iomux modes to be used for pad: GPIO_A. 000: Select mux mode: ALT0 mux port: GPIO[0] of instance: gpio1. ... So I'd say: GPIO_A is the pad name (only) and the function is better named GPIO_1_0. Best regards Uwe > > done for all the other pins with GPIO functionality. Fix for consistency. > > > > There are no mainline users that needs adaption. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > arch/arm/boot/dts/imx25-pinfunc.h | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx25-pinfunc.h > > index e14140e62b9b..55948e668410 100644 > > --- a/arch/arm/boot/dts/imx25-pinfunc.h > > +++ b/arch/arm/boot/dts/imx25-pinfunc.h > > @@ -563,15 +563,15 @@ > > #define MX25_PAD_DE_B__DE_B 0x1f0 0x3ec 0x000 0x00 0x000 > > #define MX25_PAD_DE_B__GPIO_2_20 0x1f0 0x3ec 0x000 0x05 0x000 > > > > -#define MX25_PAD_GPIO_A__GPIO_A 0x1f4 0x3f0 0x000 0x00 0x000 > > +#define MX25_PAD_GPIO_A__GPIO_1_0 0x1f4 0x3f0 0x000 0x00 0x000 > > #define MX25_PAD_GPIO_A__CAN1_TX 0x1f4 0x3f0 0x000 0x06 0x000 > > #define MX25_PAD_GPIO_A__USBOTG_PWR 0x1f4 0x3f0 0x000 0x02 0x000 > > [...] -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
