Hello Tomasz, On 15 July 2014 22:25, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > Hi Naveen, > > On 14.07.2014 07:41, Naveen Krishna Chatradhi wrote: >> Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin) >> >> spi-s3c64xx.c driver expects >> 1. chip select gpios from "cs-gpio"(singular) under the >> "controller-data" node of the client/slave device of the SPI. > > Please work a bit more on readability of your commit messages, > especially in terms of using correct terminology to avoid unnecessary > confusion. > > s/'chip select gpios'/'chip select GPIO pins'/ > s/'"cs-gpio"(singular)'/'"cs-gpio" property'/ > s/'client/slave device of the SPI'/'SPI device'/ Sure, I'm working on that. > > More things like this follow in rest of the text below. > > Otherwise I believe the code after this patch does the right thing, so: > > Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> I've submitted another patch set which does the same functionality as this patch set. I believe the new series is more cleaner in terms of patch separation and documentation. Kindly, let me know your comments on that series. http://www.spinics.net/lists/arm-kernel/msg347634.html > > Best regards, > Tomasz -- Thanks & Regards, (: Naveen :) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
