Hi, * Vignesh Raghavendra <vigneshr@xxxxxx> [210505 06:55]: > Convert i2c-omap.txt to YAML schema for better checks and documentation. Nice to see this happening, few minor comments below on handling the legacy devices. > +properties: > + compatible: > + oneOf: > + - const: ti,omap2420-i2c > + - const: ti,omap2430-i2c > + - const: ti,omap3-i2c > + - const: ti,omap4-i2c > + - items: > + - enum: > + - ti,am4372-i2c > + - ti,am64-i2c > + - ti,am654-i2c > + - ti,j721e-i2c > + - const: ti,omap4-i2c I wonder if we should just add all the compatible options to the driver, and have all these as oneOf? > + ti,hwmods: > + description: > + Must be "i2c<n>", n being the instance number (1-based) > + $ref: /schemas/types.yaml#/definitions/string > + items: > + - pattern: "^i2c([1-9])$" The ti,hwmods is a legacy property that is only needed for omap2/3 and ti81xx. At least the description should mention that to avoid folks adding it accidentally. Regards, Tony
