Hi Tony, On 07/15/2014 08:30 AM, Tony Lindgren wrote: > * Suman Anna <s-anna@xxxxxx> [140711 14:47]: >> Add the hwmod data for the 13 instances of the system mailbox >> IP in DRA7 SoC. The patch is needed for performing a soft-reset >> while configuring the respective mailbox instance, otherwise is >> a non-essential change for functionality. The modules are smart >> idled on reset, and the IP module mode is hardware controlled. >> >> Cc: Rajendra Nayak <rnayak@xxxxxx> >> Cc: Paul Walmsley <paul@xxxxxxxxx> >> Signed-off-by: Suman Anna <s-anna@xxxxxx> >> --- >> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 305 ++++++++++++++++++++++++++++++ >> 1 file changed, 305 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> index 20b4398..e35f5b1 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> @@ -939,6 +939,194 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = { >> }; >> >> /* >> + * 'mailbox' class >> + * >> + */ >> + >> +static struct omap_hwmod_class_sysconfig dra7xx_mailbox_sysc = { >> + .rev_offs = 0x0000, >> + .sysc_offs = 0x0010, >> + .sysc_flags = (SYSC_HAS_RESET_STATUS | SYSC_HAS_SIDLEMODE | >> + SYSC_HAS_SOFTRESET), >> + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >> + .sysc_fields = &omap_hwmod_sysc_type2, >> +}; >> + >> +static struct omap_hwmod_class dra7xx_mailbox_hwmod_class = { >> + .name = "mailbox", >> + .sysc = &dra7xx_mailbox_sysc, >> +}; > > Hmm I'm seeing just the following MAILBOX_SYSCONFIG in at least > am57xx TRM: > > 31:4 RESERVED > 3:2 SIDLEMODE 0 = force-idle 1 = no-idle, 2 = smart-idle, 3 = reserved > 1 RESERVED > 0 SOFTRESET > > So it seems that SYSC_HAS_RESET_STATUS above is wrong? Can you guys > please check. The same SOFTRESET bit is used for both triggering the softreset and reading the reset done status. Once you write a 1 to trigger a reset, the bit will be cleared once the reset is done. This is no different from OMAP4. The logic in _wait_softreset_complete in omap_hwmod.c was already designed to work with this properly. regards Suman -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html