Am Freitag, dem 30.04.2021 um 15:14 +0800 schrieb Peng Fan (OSS): > > On 2021/4/29 22:34, Lucas Stach wrote: > > Am Donnerstag, dem 29.04.2021 um 15:30 +0800 schrieb Peng Fan (OSS): > > > From: Peng Fan <peng.fan@xxxxxxx> > > > > > > i.MX8MM has blk ctl module, the handshake can only finish after setting > > > blk ctl. The blk ctl driver will set the bus clk bit and the handshake > > > will finish there. we just add a delay and suppose the handshake will > > > finish after that. > > > > Instead of this patch, just drop patch 05/16 from this series. I think > > we should leave a comment in the code on why we aren't waiting for the > > handshake ack, as this is non-obvious from looking at the driver code. > > > > Basically add a polished version of the commit log from this patch into > > the driver code. > > After thinking more, for power down, we need wait handshake. For power > up, we could ignore handshake, because BLK-CTL setting bus clk en > will auto trigger handshake. > > For power down, the bus clk en already set, and we need wait, otherwise > we need add delay there. > > So I would only drop the power up waiting and add some comments there. Ah, right. This way makes a lot of sense. Regards, Lucas