Re: [PATCH v3 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 28/04/2021 16.19, Jonathan Cameron wrote:
+static int fxls8962af_get_temp(struct fxls8962af_data *data, int *val)
+{
+	struct device *dev = regmap_get_device(data->regmap);
+	unsigned int value;
+	int ret;
+
+	ret = fxls8962af_drdy(data);
I'm a little confused.  You check data is ready before calling power on
which could result in you moving from standby to active state?


Reading it again, I would definitively move it around :)
When testing it looks like we currently are getting the last sample from active state.

/Sean



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux