Re: [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi

[David Wu <david.wu@xxxxxxxxxxxxxx>]

Hi Ezequiel,

在 2021/4/26 上午10:41, Ezequiel Garcia 写道:
> Rockchip DWMAC glue driver uses the phy node (phy-handle)
> reset specifier, and not a "mac-phy" reset specifier.
>
> Remove it.

Well done, the "mac-phy" reset is not part of the controller. So

Reviewed-by: David Wu <david.wu@xxxxxxxxxxxxxx>

> Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 5bab61784735..3ed69ecbcf3c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -916,8 +916,8 @@ gmac2phy: ethernet@ff550000 {
>   			      "mac_clk_tx", "clk_mac_ref",
>   			      "aclk_mac", "pclk_mac",
>   			      "clk_macphy";
> -		resets = <&cru SRST_GMAC2PHY_A>, <&cru SRST_MACPHY>;
> -		reset-names = "stmmaceth", "mac-phy";
> +		resets = <&cru SRST_GMAC2PHY_A>;
> +		reset-names = "stmmaceth";
>   		phy-mode = "rmii";
>   		phy-handle = <&phy>;
>   		snps,txpbl = <0x4>;