These two devices differ from the AT93C46 by their storage size, respectively 2 Kib and 4 Kib, while the AT93C46 contains 1 Kib. The driver was currently hardcoding that addrlen == 7 means 8-bit words, and anything else means 16-bit words. This is obviously not going to work with more storage and thus more bits spent on the address (for instance on the AT93C66 in 8-bit words mode, addrlen == 9 since there are 512 bytes to address), so I’m now doing those checks based on the word size specified in the device tree. It might make sense to rename this driver now that it supports all three sizes, but I don’t know what would be a good name, eeprom_93xxx6 doesn’t sound very nice. I have tested this series on a Nintendo Wii U, on the downstream linux-wiiu kernel based on 4.19, and thus only with a AT93C66. You can find this work here if you want to test it: https://gitlab.com/linux-wiiu/linux-wiiu/-/merge_requests/16 Changes since v1: - Reordered and squashed patches. - Split out the dts addition. - Removed a bogus goto. - Improved commit messages to make what they do more explicit. Emmanuel Gil Peyrot (3): misc: eeprom_93xx46: Remove hardcoded bit lengths misc: eeprom_93xx46: Add new 93c56 and 93c66 compatible strings dts: eeprom-93xx46: Add support for 93C46, 93C56 and 93C66 .../bindings/misc/eeprom-93xx46.txt | 3 + drivers/misc/eeprom/eeprom_93xx46.c | 90 +++++++++++++------ include/linux/eeprom_93xx46.h | 3 + 3 files changed, 69 insertions(+), 27 deletions(-) -- 2.31.1
