Hi Emmanuel, Thank you for the patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on soc/for-next robh/for-next linux/master linus/master v5.12-rc8 next-20210423] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Emmanuel-Gil-Peyrot/eeprom-93xx46-Add-support-for-Atmel-AT93C56-and-AT93C66/20210424-204020 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git e2cb6b891ad2b8caa9131e3be70f45243df82a80 config: riscv-randconfig-r036-20210424 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 3d1aecbd285709f58168b3ad65c06da4b42132a9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/46b220709479fc35862b671390a11c6da2ec4d08 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Emmanuel-Gil-Peyrot/eeprom-93xx46-Add-support-for-Atmel-AT93C56-and-AT93C66/20210424-204020 git checkout 46b220709479fc35862b671390a11c6da2ec4d08 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:556:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] return inb(addr); ^~~~~~~~~ arch/riscv/include/asm/io.h:55:76: note: expanded from macro 'inb' #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ~~~~~~~~~~ ^ arch/riscv/include/asm/mmio.h:87:48: note: expanded from macro 'readb_cpu' #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) ^ In file included from drivers/misc/eeprom/eeprom_93xx46.c:16: In file included from include/linux/of_gpio.h:14: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:564:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] return inw(addr); ^~~~~~~~~ arch/riscv/include/asm/io.h:56:76: note: expanded from macro 'inw' #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ~~~~~~~~~~ ^ arch/riscv/include/asm/mmio.h:88:76: note: expanded from macro 'readw_cpu' #define readw_cpu(c) ({ u16 __r = le16_to_cpu((__force __le16)__raw_readw(c)); __r; }) ^ include/uapi/linux/byteorder/little_endian.h:36:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from drivers/misc/eeprom/eeprom_93xx46.c:16: In file included from include/linux/of_gpio.h:14: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:572:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] return inl(addr); ^~~~~~~~~ arch/riscv/include/asm/io.h:57:76: note: expanded from macro 'inl' #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ~~~~~~~~~~ ^ arch/riscv/include/asm/mmio.h:89:76: note: expanded from macro 'readl_cpu' #define readl_cpu(c) ({ u32 __r = le32_to_cpu((__force __le32)__raw_readl(c)); __r; }) ^ include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from drivers/misc/eeprom/eeprom_93xx46.c:16: In file included from include/linux/of_gpio.h:14: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:580:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] outb(value, addr); ^~~~~~~~~~~~~~~~~ arch/riscv/include/asm/io.h:59:68: note: expanded from macro 'outb' #define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) ~~~~~~~~~~ ^ arch/riscv/include/asm/mmio.h:91:52: note: expanded from macro 'writeb_cpu' #define writeb_cpu(v, c) ((void)__raw_writeb((v), (c))) ^ In file included from drivers/misc/eeprom/eeprom_93xx46.c:16: In file included from include/linux/of_gpio.h:14: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:588:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] outw(value, addr); ^~~~~~~~~~~~~~~~~ arch/riscv/include/asm/io.h:60:68: note: expanded from macro 'outw' #define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) ~~~~~~~~~~ ^ arch/riscv/include/asm/mmio.h:92:76: note: expanded from macro 'writew_cpu' #define writew_cpu(v, c) ((void)__raw_writew((__force u16)cpu_to_le16(v), (c))) ^ In file included from drivers/misc/eeprom/eeprom_93xx46.c:16: In file included from include/linux/of_gpio.h:14: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:596:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] outl(value, addr); ^~~~~~~~~~~~~~~~~ arch/riscv/include/asm/io.h:61:68: note: expanded from macro 'outl' #define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) ~~~~~~~~~~ ^ arch/riscv/include/asm/mmio.h:93:76: note: expanded from macro 'writel_cpu' #define writel_cpu(v, c) ((void)__raw_writel((__force u32)cpu_to_le32(v), (c))) ^ In file included from drivers/misc/eeprom/eeprom_93xx46.c:16: In file included from include/linux/of_gpio.h:14: In file included from include/linux/gpio/driver.h:7: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/riscv/include/asm/io.h:149: include/asm-generic/io.h:1005:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port; ~~~~~~~~~~ ^ >> drivers/misc/eeprom/eeprom_93xx46.c:487:8: error: use of undeclared label 'fail' goto fail; ^ 7 warnings and 1 error generated. vim +/fail +487 drivers/misc/eeprom/eeprom_93xx46.c 455 456 static int eeprom_93xx46_probe(struct spi_device *spi) 457 { 458 struct eeprom_93xx46_platform_data *pd; 459 struct eeprom_93xx46_dev *edev; 460 int err; 461 462 if (spi->dev.of_node) { 463 err = eeprom_93xx46_probe_dt(spi); 464 if (err < 0) 465 return err; 466 } 467 468 pd = spi->dev.platform_data; 469 if (!pd) { 470 dev_err(&spi->dev, "missing platform data\n"); 471 return -ENODEV; 472 } 473 474 edev = devm_kzalloc(&spi->dev, sizeof(*edev), GFP_KERNEL); 475 if (!edev) 476 return -ENOMEM; 477 478 if (pd->flags & EE_SIZE1K) 479 edev->size = 128; 480 else if (pd->flags & EE_SIZE2K) 481 edev->size = 256; 482 else if (pd->flags & EE_SIZE4K) 483 edev->size = 512; 484 else { 485 dev_err(&spi->dev, "unspecified size\n"); 486 err = -EINVAL; > 487 goto fail; 488 } 489 490 if (pd->flags & EE_ADDR8) 491 edev->addrlen = ilog2(edev->size); 492 else if (pd->flags & EE_ADDR16) 493 edev->addrlen = ilog2(edev->size) - 1; 494 else { 495 dev_err(&spi->dev, "unspecified address type\n"); 496 return -EINVAL; 497 } 498 499 mutex_init(&edev->lock); 500 501 edev->spi = spi; 502 edev->pdata = pd; 503 504 edev->nvmem_config.type = NVMEM_TYPE_EEPROM; 505 edev->nvmem_config.name = dev_name(&spi->dev); 506 edev->nvmem_config.dev = &spi->dev; 507 edev->nvmem_config.read_only = pd->flags & EE_READONLY; 508 edev->nvmem_config.root_only = true; 509 edev->nvmem_config.owner = THIS_MODULE; 510 edev->nvmem_config.compat = true; 511 edev->nvmem_config.base_dev = &spi->dev; 512 edev->nvmem_config.reg_read = eeprom_93xx46_read; 513 edev->nvmem_config.reg_write = eeprom_93xx46_write; 514 edev->nvmem_config.priv = edev; 515 edev->nvmem_config.stride = 4; 516 edev->nvmem_config.word_size = 1; 517 edev->nvmem_config.size = edev->size; 518 519 edev->nvmem = devm_nvmem_register(&spi->dev, &edev->nvmem_config); 520 if (IS_ERR(edev->nvmem)) 521 return PTR_ERR(edev->nvmem); 522 523 dev_info(&spi->dev, "%d-bit eeprom containing %d bytes %s\n", 524 (pd->flags & EE_ADDR8) ? 8 : 16, 525 edev->size, 526 (pd->flags & EE_READONLY) ? "(readonly)" : ""); 527 528 if (!(pd->flags & EE_READONLY)) { 529 if (device_create_file(&spi->dev, &dev_attr_erase)) 530 dev_err(&spi->dev, "can't create erase interface\n"); 531 } 532 533 spi_set_drvdata(spi, edev); 534 return 0; 535 } 536 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
